chore: bump version to 2.1.4

chore(deps): bump shivammathur/setup-php from 2.37.1 to 2.37.2 in the actions group

.github/workflows/tests.yml

@@ -18,10 +18,10 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
 
       - name: Setup PHP
-        uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # v2
+        uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # v2
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, gd, redis, memcached

composer.json

@@ -1,6 +1,6 @@
 {
   "name": "wearepixel/laravel-cart",
-  "version": "2.1.1",
+  "version": "2.1.4",
   "description": "A cart implementation for Laravel",
   "keywords": [
     "laravel",

src/CartSession.php

@@ -159,10 +159,8 @@ public function clear()
 
         $deleted = $this->session->delete();
 
-        $this->session = [
-            $this->itemsKey => [],
-            $this->conditionsKey => [],
-        ];
+        $this->session[$this->itemsKey] = [];
+        $this->session[$this->conditionsKey] = [];
 
         return $deleted;
     }

src/Facades/CartFacade.php

@@ -14,7 +14,7 @@
  *
  * @method static ItemCollection|null get(int|string $itemId)
  * @method static bool has(int|string $itemId)
- * @method static void add(int|string $id, string $name, int|float $price, int $quantity, array $attributes = [], CartCondition|array $conditions = [], string $associatedModel = '')
+ * @method static self add(string|int|array<string, mixed> $id, string|null $name = null, float|null $price = null, int|float|null $quantity = null, array<string, mixed> $attributes = [], CartCondition|array<mixed> $conditions = [], string|null $associatedModel = null)
  * @method static bool update(int|string $id, array $data)
  * @method static void remove(int|string $id)
  * @method static void clear()

tests/Unit/DatabaseCartTest.php

@@ -123,4 +123,23 @@
         expect($this->cart->getContent()->count())->toEqual(0, 'Cart content should be 0');
         expect(MockCartModel::all()->count())->toEqual(0, 'The carts database table should have 0 rows');
     });
+
+    test('can clear cart conditions after clearing the cart', function () {
+        $condition = new CartCondition([
+            'name' => '10% Off',
+            'type' => 'coupon',
+            'target' => 'subtotal',
+            'value' => '-10%',
+        ]);
+
+        $this->cart->add(1, 'Sample Item', 100.99, 2, []);
+        $this->cart->condition($condition);
+
+        $this->cart->clear();
+
+        // This was throwing "Call to a member function save() on array"
+        // because clear() replaced $this->session with a plain array
+        expect(fn () => $this->cart->clearCartConditions())->not->toThrow(Error::class);
+        expect($this->cart->getConditions())->toBeEmpty();
+    });
 });