Add items with no price

This commit is contained in:
Joel Male
2024-08-26 10:38:20 +10:00
parent e49ebe02e0
commit 54d94d8d12
4 changed files with 21 additions and 5 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "wearepixel/laravel-cart",
"version": "1.0.4",
"version": "1.0.5",
"description": "A cart implementation for Laravel",
"keywords": [
"laravel",
+6 -3
View File
@@ -164,6 +164,7 @@ public function add(
$this->add(
$id['id'],
$id['name'],
// isset($id['price']) ? $id['price'] : null,
$id['price'],
$id['quantity'],
Helpers::issetAndHasValueOrAssignDefault($id['attributes'], []),
@@ -698,15 +699,17 @@ protected function validate($item)
{
$rules = [
'id' => 'required',
'price' => 'required|numeric',
'quantity' => 'required|numeric|min:0.1',
'name' => 'required',
'quantity' => 'required|numeric|min:0.1',
];
$validator = CartItemValidator::make($item, $rules);
if ($validator->fails()) {
throw new InvalidItemException($validator->messages()->first());
// if the error is due to quantity
if ($validator->errors()->first('quantity') === 'The quantity must be at least 0.1.') {
throw new InvalidItemException('The quantity must be at least 0.1.');
}
}
return $item;
+1 -1
View File
@@ -7,7 +7,7 @@ class Helpers
/**
* Normalize prices
*/
public static function normalizePrice($price): float
public static function normalizePrice($price): ?float
{
return (is_string($price)) ? floatval($price) : $price;
}
+13
View File
@@ -49,6 +49,19 @@
expect($this->cart->getTotal())->toEqual(0, 'Total should be 0');
});
test('can add an item an array with no price', function () {
$this->cart->add([
'id' => 455,
'name' => 'Sample Item',
'quantity' => 2,
]);
expect($this->cart->isEmpty())->toBeFalse('Cart should not be empty');
expect($this->cart->getContent()->count())->toEqual(1, 'Cart content should be 1');
expect($this->cart->getContent()->first()['id'])->toEqual(455, 'Item added has ID of 455 so first content ID should be 455');
expect($this->cart->getTotal())->toEqual(0, 'Total should be 0');
})->only();
test('can add an item without attributes', function () {
$item = [
'id' => 1,