pixel/laravel-cart
1
0
Fork 0
mirror of https://github.com/wearepixel/laravel-cart.git synced 2026-11-14 13:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix tests & validation errors

Browse Source
This commit is contained in:
Joel Male
2024-08-26 10:57:02 +10:00
parent 7d955d722c
commit 6604cf984d
2 changed files with 30 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Cart.php
+11 -5
View File
@@ -153,7 +153,7 @@ public function add(
$this->add(
$item['id'],
$item['name'],
$item['price'],
isset($item['price']) ? $item['price'] : null,
$item['quantity'],
Helpers::issetAndHasValueOrAssignDefault($item['attributes'], []),
Helpers::issetAndHasValueOrAssignDefault($item['conditions'], []),
@@ -164,8 +164,7 @@ public function add(
$this->add(
$id['id'],
$id['name'],
// isset($id['price']) ? $id['price'] : null,
$id['price'],
isset($id['price']) ? $id['price'] : null,
$id['quantity'],
Helpers::issetAndHasValueOrAssignDefault($id['attributes'], []),
Helpers::issetAndHasValueOrAssignDefault($id['conditions'], []),
@@ -706,8 +705,15 @@ protected function validate($item)
$validator = CartItemValidator::make($item, $rules);
if ($validator->fails()) {
// if the error is due to quantity
if ($validator->errors()->first('quantity') === 'The quantity must be at least 0.1.') {
if ($validator->errors()->first('id') === 'validation.required') {
throw new InvalidItemException('The id field is required.');
}
if ($validator->errors()->first('name') === 'validation.required') {
throw new InvalidItemException('The name field is required.');
}
if ($validator->errors()->first('quantity') === 'validation.min.numeric') {
throw new InvalidItemException('The quantity must be at least 0.1.');
}
}